[Graphics Settings Strippers] Adding null checks to avoid exceptions.

Fixing null ref exception. https://jira.unity3d.com/browse/UUM-74223
Unity-Technologies · Jul 1, 2024 · 206c513 · 206c513
1 parent 25d2b94
commit 206c513
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/...m.unity.render-pipelines.core/Runtime/Stripping/RenderPipelineGraphicsSettingsStripper.cs b/...m.unity.render-pipelines.core/Runtime/Stripping/RenderPipelineGraphicsSettingsStripper.cs
@@ -10,6 +10,9 @@ internal static partial class RenderPipelineGraphicsSettingsStripper
     {
         private static bool CanRemoveSettings(this List<IStripper> strippers, [DisallowNull] Type settingsType, [DisallowNull] IRenderPipelineGraphicsSettings settings)
         {
+            if (strippers == null)
+                return false;
+
             const BindingFlags flags = BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance;
 
             var canRemoveSettings = true;
@@ -18,7 +21,7 @@ private static bool CanRemoveSettings(this List<IStripper> strippers, [DisallowN
 
             foreach (var stripperInstance in strippers)
             {
-                var methodInfo = stripperInstance.GetType().GetMethod($"{nameof(IRenderPipelineGraphicsSettingsStripper<IRenderPipelineGraphicsSettings>.CanRemoveSettings)}", flags);
+                var methodInfo = stripperInstance?.GetType().GetMethod($"{nameof(IRenderPipelineGraphicsSettingsStripper<IRenderPipelineGraphicsSettings>.CanRemoveSettings)}", flags);
                 if (methodInfo != null)
                     canRemoveSettings &= (bool)methodInfo.Invoke(stripperInstance, methodArgs);
             }
@@ -36,8 +39,7 @@ private static bool CanTransferSettingsToPlayer(
             strippersDefined = false;
 
             var settingsType = settings.GetType();
-
-            if (strippersMap.TryGetValue(settingsType, out var strippers))
+            if (strippersMap.TryGetValue(settingsType, out var strippers) && strippers != null)
             {
                 if (!strippers.CanRemoveSettings(settingsType, settings))
                     isAvailableOnPlayerBuild = true;
@@ -80,7 +82,7 @@ public static void PerformStripping(
                     report.AddStrippedSetting(settings.GetType(), isAvailableOnPlayerBuild, strippersDefined);
                 }
             }
-            
+
         }
     }
 }