This repository has been archived by the owner on Apr 25, 2024. It is now read-only.
fix: throw on non matching trade types #172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hensha256
reviewed
Apr 2, 2024
src/entities/protocols/uniswap.ts
Outdated
| @@ -260,6 +264,10 @@ function addMixedSwap<TInput extends Currency, TOutput extends Currency>( | |||
| } | |||
| } | |||
|
|
|||
| if(tradeType !== TradeType.EXACT_INPUT) { | |||
There was a problem hiding this comment.
why is this one only exact in and not exact out too?
There was a problem hiding this comment.
We only support mixed routes for EXACT_INPUT: https://github.com/Uniswap/router-sdk/blob/main/src/entities/mixedRoute/trade.ts#L200 , not sure exactly why
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an incorrect trade type is passed into this SDK, it is possible for no calldata to be built at all which is a footgun and should be avoided. This PR throws explicitly on non matching trade types when building uniswap trades.