This repository has been archived by the owner on Apr 25, 2024. It is now read-only.
feat: add router trade adapter #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongeric
commented
Mar 20, 2024
src/entities/protocols/uniswap.ts
Outdated
Comment on lines
57
to
60
| if(this.options.payerIsUser === undefined) { | ||
| // default to user as payer | ||
| Object.assign(this.options, { payerIsUser: true }) | ||
| } |
There was a problem hiding this comment.
This PR also allows for the overriding of payerIsUser within SwapOptions. This is intended to be fully backward compatible - in that the default value is true if not specified.
marktoda
suggested changes
Mar 27, 2024
marktoda
approved these changes
Mar 29, 2024
src/entities/protocols/uniswap.ts
Outdated
| @@ -31,6 +31,7 @@ export type FlatFeeOptions = { | |||
| // so we extend swap options with the permit2 permit | |||
| // when safe mode is enabled, the SDK will add an extra ETH sweep for security | |||
| export type SwapOptions = Omit<RouterSwapOptions, 'inputTokenPermit'> & { | |||
| directSend?: boolean | |||
There was a problem hiding this comment.
little comment explaining what this means would be useful, and not 100% sure on the name but can't think of anything much better haha
There was a problem hiding this comment.
Ok maybe something like useRouterBalance is more appropriate and comment like // when useRouterBalance is enabled the SDK will use the balance in the router for the swap
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code for converting a response from our routing services (classic quote) into Trade SDK objects is fragmented and duplicated in many areas: notably in the interface and external api.
This PR introduces a helper class
RouterTradeAdapterwhich has a static methodfromClassicQuotethat constructs the underlyingRouterTradeentity (from router-sdk). TheRouterTradeentity can easily be used to create the UniversalRouterTrade entity in this SDK.