Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert V3 Candidate Pool Selection #340

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

mikeki
Copy link
Contributor

@mikeki mikeki commented Aug 22, 2023

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    This is a backup plan in case the latest deploy doesn't work as we expect, we would revert the v3 heruistic changes to get the latency back to normal levels

Copy link
Member

@jsy1218 jsy1218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast approval, just in case

@mikeki mikeki merged commit bae08c8 into main Aug 23, 2023
7 checks passed
@mikeki mikeki deleted the mikeki/revert_v3_candidate_pools_change branch August 23, 2023 00:24
@mikeki mikeki mentioned this pull request Aug 23, 2023
mikeki added a commit that referenced this pull request Aug 23, 2023
mikeki added a commit that referenced this pull request Aug 23, 2023
* Revert "Revert V3 Candidate Pool Selection (#340)"

This reverts commit bae08c8.

* Dedup V3 SubgraphPools

* debug

* debug more

* Fix heuristics

* remove debugging

* Revert "remove debugging"

This reverts commit d04adf4.

* topByBaseNotDirect

* Revert "Revert "remove debugging""

This reverts commit e69895f.

* Update V2 too

* add to list of seen so far
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants