mixed route eth -> uni test that repro smarter pool filter mixed route failure #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsy1218
changed the title
mikeki
approved these changes
Aug 22, 2023
jsy1218
deleted the
jsy1218/repro-mixed-failure-for-smarter-pool-filter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
integ-test coverage enhancement
What is the current behavior? (You can also link to an open issue here)
Adding ETH -> UNI using
mixedprotocol, that should force to use V2. The test should pass against main branch.What is the new behavior (if this is a feature change)?
I noticed during local testing, that with Update HeuristicsFiltering #331, mixed route doesn't always find the route. I wrote this test to consistently repro the no swap route for Update HeuristicsFiltering #331, and we can further QA before checking in.
Other information: