Unique Chain 1.14 #1096
Open
Unique Chain 1.14 #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BuddyGlas
added
CI-just-tests
CertainLach
requested changes
Dec 16, 2024
.baedeker/just-tests.jsonnet
Outdated
| modify:: bdk.mixer([ | ||
| m.genericRelay($), | ||
| { | ||
| genesis+: { |
There was a problem hiding this comment.
Обновите на simplify+_genesis, выяснили что runtimeGenesis формат устарел
There was a problem hiding this comment.
это тестовый файл, на него не обращай внимания.
.baedeker/xcm-quartz.jsonnet
Outdated
| @@ -26,7 +26,7 @@ local relay = { | |||
| wantedKeys: 'relay', | |||
| expectedDataPath: '/parity', | |||
| }, | |||
| for name in ['alice', 'bob', 'charlie', 'dave', 'eve', 'ferdie'] | |||
| for name in ['alice', 'bob', 'charlie', 'dave', 'eve', 'ferdie', 'gregory', 'holly', 'iggy', 'john', 'kurt'] | |||
There was a problem hiding this comment.
- пропущена конфигурация async-backing, для последней версии реле она требуется
| # of it to this day (Ignoring incremental compilation, which is explicitly disabled by CARGO_INCREMENTAL=0). Only the | ||
| # fully built crates will be cached depending on the crate source, version and feature set, which are locked by | ||
| # Cargo.lock, which can't be updated because of the --locked flag. | ||
| RUN --mount=type=cache,target=/cargo-home/registry \ |
There was a problem hiding this comment.
Кеш был для локальных сборок, он не вредит, и игнорируется с --no-cache который стоит у нас на CI, давайте его оставим, я его уже N раз возвращал, но его N+1 раз удаляли)
| CARGO_INCREMENTAL=0 cargo build --release --features="${FEATURES}" --locked && \ | ||
| mv ./target/release/unique-collator /unique_parachain/unique-chain/ | ||
| mv ./target/release/unique-collator /workdir/unique-chain/ && \ | ||
| cd target/release/wbuild && find . -name "*.wasm" -exec sh -c 'mkdir -p "../../../wasm/$(dirname {})"; cp {} "../../../wasm/{}"' \; |
There was a problem hiding this comment.
Для /wasm давайте абсолютный путь использовать, а то читать тяжело)
| @@ -138,7 +169,9 @@ jobs: | |||
| inputs: | | |||
| .baedeker/forkless-data.jsonnet | |||
| snippet:(import 'baedeker-library/ops/rewrites.libsonnet').rewriteNodePaths({'bin/polkadot':{dockerImage:'${{ steps.polkadot.outputs.image }}:${{ steps.polkadot.outputs.tag }}'}}) | |||
| snippet:(import 'baedeker-library/ops/rewrites.libsonnet').rewriteNodePaths({'bin/unique':{dockerImage:'${{ steps.latest.outputs.name }}'}}, extra_node_mixin={extraArgs: []}) | |||
| # with data build uses old runtime, but new node, thus we use mainnet image for spec generation, and then target image for nodes. | |||
| snippet:(import 'baedeker-library/ops/rewrites.libsonnet').rewriteNodePaths({'bin/unique':{dockerImage:'${{ steps.node.outputs.name }}'}}, extra_node_mixin={extraArgs: []}, for_chain = false) | |||
There was a problem hiding this comment.
Внимание: тут ОЧИЩАЕТСЯ extraArgs, не уверен что нам это нужно
There was a problem hiding this comment.
Этот воркфлоу будет удалён
| inputs: | | ||
| .baedeker/just-tests.jsonnet | ||
| snippet:(import 'baedeker-library/ops/rewrites.libsonnet').rewriteNodePaths({'bin/polkadot':{dockerImage:'${{ steps.polkadot.outputs.image }}:${{ steps.polkadot.outputs.tag }}'}}) | ||
| snippet:(import 'baedeker-library/ops/rewrites.libsonnet').rewriteNodePaths({'bin/unique':{dockerImage:'${{ steps.node.outputs.name }}'}}, extra_node_mixin={extraArgs: []}) |
There was a problem hiding this comment.
Очищается extraArgs, перепроверьте что это нам нужно
There was a problem hiding this comment.
Этот воркфлоу будет удалён
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Much-anticipated update of Unique to Polkadot 1.14.
This update has been prepared through the joint efforts of @fairax, @BuddyGlas, myself, and @mrshiposha.
In this update
Despite the release of version 1.16.1, we decided to keep the SDK version at 1.14 as it has already been tested and works great.
Regarding the previous PR #1091, I have restructured the commit history and corrected all messages, as well as added the missing changes.
Update note №1
The node in this release with Async Backing performs very poorly. To address this, it was decided to update the node separately to the latest Polkadot SDK to enable Fork Aware Tx Pool in a separate branch. After the new release from Parity, the branches may be merged.
Update note №2
The release has been delayed so much that many outdated branches with intermediate changes have formed during the process. After a successful release, we need to remember to clean up.