Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add F401 rule (unused imports) to ruff #976

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

johannaengland
Copy link
Contributor

Dependent on #972, #973, #974 and #975.

Slightly up for discussion (if we do not add it, then we have to remove it from the Argus-HTMX workflow)

@johannaengland johannaengland added the discussion Requires developer feedback/discussion before implementation label Nov 27, 2024
@johannaengland johannaengland self-assigned this Nov 27, 2024
Copy link

sonarcloud bot commented Nov 27, 2024

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.01%. Comparing base (433a93a) to head (47e9e58).

Files with missing lines Patch % Lines
...rc/argus/notificationprofile/media/sms_as_email.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #976      +/-   ##
==========================================
+ Coverage   82.97%   83.01%   +0.03%     
==========================================
  Files          99       99              
  Lines        4330     4303      -27     
==========================================
- Hits         3593     3572      -21     
+ Misses        737      731       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hmpf hmpf added the linting label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Requires developer feedback/discussion before implementation linting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants