Move argus-htmx files to correct place in the argus-server tree #955
Conversation
hmpf
force-pushed
the
move-argus-htmx-to-correct-place
branch
from
bb1b7ba
to
af722e9
Compare
hmpf
force-pushed
the
move-argus-htmx-to-correct-place
branch
from
740dada
to
6cf138d
Compare
hmpf
added
refactor
documentation
hmpf
force-pushed
the
move-argus-htmx-to-correct-place
branch
from
2975ca5
to
fd838a0
Compare
| # OS specific | ||
| src/argus/htmx/tailwindtheme/tailwindcss |
There was a problem hiding this comment.
perhaps make it more clear that this is an optional executable that may be put there
There was a problem hiding this comment.
Yeah need to check with @podliashanyk if this needs to be in the package or not. We might have to publish a wheel per platform. Not a problem to be solved this week!
There was a problem hiding this comment.
I don't think it should be packaged. It's a development tool for creating the styles.css (which is included in the package)
Improve some of the docs mentioning urls.py for readability.
.. with some changes because setuptools uses .gitignore to decide what files to include in the package while flit does not.
(Why weren't there automated complaints about this before?)
Set ROOT_URLCONF to path+"root_urls" instead of path+"urls" so that urls.py can be dedicated only to the endpoints added by the app
argus_htmx depends on both django_htmx and widget_tweaks so let's load it at the end to underline that fact.
hmpf
force-pushed
the
move-argus-htmx-to-correct-place
branch
from
d09d608
to
ff04c77
Compare
It does not like implicit POST.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #955 +/- ##
==========================================
- Coverage 82.97% 75.91% -7.07%
==========================================
Files 99 132 +33
Lines 4330 4874 +544
==========================================
+ Hits 3593 3700 +107
- Misses 737 1174 +437 ☔ View full report in Codecov by Sentry. |
| Example, top of settings-file for development:: | ||
|
|
||
| from argus.site.settings.dev import * | ||
| from argus.site.utils import update_settings | ||
| from argus.htmx.appconfig import APP_SETTINGS | ||
|
|
||
| update_settings(globals(), APP_SETTINGS) |
There was a problem hiding this comment.
Well, I tried this, but it doesn't seem to actually update my urlconfig, so the htmx frontend is still "missing" from the server. What am I misunderstanding about these instructions?
|
This depends on #952
If you have the frontend working with the argus_htmx standalone app, change "argus_htmx" to "argus.htmx" in your local settings file. If you have fiddled with the tailwind settings, also make sure to replace "argus_htmx" in file paths with "argus/htmx".