-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some openapi warnings #897
Conversation
ad2c7a9
to
0abfb59
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #897 +/- ##
==========================================
- Coverage 84.20% 84.18% -0.03%
==========================================
Files 89 90 +1
Lines 4040 4065 +25
==========================================
+ Hits 3402 3422 +20
- Misses 638 643 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how to review this. I think it looks fine. Doensn't seem to impact us. Always good to fix warnings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it manually and it does what it promises.
This one probably needs a changelog fragment, and there is an unused import that can be removed
0abfb59
to
14a37c0
Compare
.. also ensure that the serializer is valid in tests. The first attempt pk was required and the tests failed in the wrong place.
14a37c0
to
988f957
Compare
Quality Gate passedIssues Measures |
Test by visiting "/api/v1/schema/swagger-ui/" and "/api/v2/schema/swagger-ui/" without and with these commits, the list of warnings dumped to the terminal should be shorter.
Does not fix:
I have no idea where to start on the first, as for the last, I cannot figure out where drf-spectacular finds something to interpret as EventTypesEnum. There is also TypeEnum with the same contents. Setting ENUM_NAME_OVERRIDES does nothing.
Also does not fix (#903):
I'm thinking fixing one of the above will yield the solution for all four.