Extract AO and VoxelGenerator from SphereRenderer #1202
+1,049
−642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
October 29, 2022 17:29
…mbientOcclusion()
|
|
Style check found formatting issues! Comment |
|
/format |
Hint: it's a bit weirdly squished in Y
geringsj
reviewed
Sep 19, 2023
|
|
||
| bool megamol::compositing_gl::AO::recreateResources(void) { | ||
|
|
||
| auto const& ogl_ctx = frontend_resources.get<frontend_resources::OpenGL_Context>(); //TODO necessary? |
geringsj
reviewed
Sep 20, 2023
Comment on lines
+374
to
+380
| // Draw screen filling 'quad' (2 triangle, front facing: CCW) | ||
| std::vector<GLfloat> vertices = {-1.0f, -1.0f, 1.0f, 1.0f, -1.0f, 1.0f, -1.0f, -1.0f, 1.0f, -1.0f, 1.0f, 1.0f}; | ||
| GLuint vert_attrib_loc = glGetAttribLocation(this->lighting_prgm_->getHandle(), "inPosition"); | ||
| glEnableVertexAttribArray(vert_attrib_loc); | ||
| glVertexAttribPointer(vert_attrib_loc, 2, GL_FLOAT, GL_TRUE, 0, vertices.data()); | ||
| glDrawArrays(GL_TRIANGLES, static_cast<GLint>(0), static_cast<GLsizei>(vertices.size() / 2)); | ||
| glDisableVertexAttribArray(vert_attrib_loc); |
There was a problem hiding this comment.
It should suffice to do the quad preparation once before rendering, instead of every frame.
geringsj
reviewed
Sep 20, 2023
Comment on lines
+99
to
+101
| GLuint texture_handle; | ||
| GLuint vertex_array_; | ||
| GLuint vbo_; |
There was a problem hiding this comment.
Would it make things easier to use glowl helpers here?
geringsj
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract parts of the SphereRenderer into seperate modules
Summary of Changes
New modules
Test Instructions
Use the following project to test the new modules (remove ".txt")
AO.lua.txt