Fix build failing in dependency setup #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is a really bad idea to pull the last 100 commits and then hope that the commit you want to checkout is still among those. It is a time bomb that breaks builds at random times over the years. Now the pull command pulls that one commit directly.
|
lgtm, thanks for the improvement. The CI build failed because of unrelated Unity issue "License activation strategy could not be determined". |
|
The download dependencies bash scripts are not a very good solution in the first place. Maybe Cake (C# Make) would be a better solution. I think writing the download dependencies scripts in C# would make sense given that Unity also uses C# Another approach could be to add a Menu Item in the Unity editor that runs the corresponding setup code in C#. |
basisbit
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the currently failing build. It fixes a bug in the dependency download scripts that caused libraries to not be found. See commit message for technical details.
Closes Issue(s)
Motivation
The build was failing. There was a time bomb like behavior in the dependency download scripts where builds could break at any time if a library developer decided to make more than 100 commits after the one that Ultrastar Play depended on. The SharpZipLib dependency failed to download because of this bug.
More
Additional Notes