Fix key stucks caused by (high) keystroke delays. #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should I test on a UHK 60 or 80? |
|
Whichever you like. I think I used uhk 80 to reproduce the problem. |
|
I can easily reproduce the issue, and this PR fixes it. From now on, I'll test it on my UHK 60 v2. |
kareltucek
changed the title
|
Well I don't have any new insights about this, so feel free to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproduction steps:
This fixes the above and also refactors keystrokeDelay implementation so that the eventloop doesn't spin in the meantime.
Please don't merge yet. This needs a bit more thinking when I am fresh. However, feel free to start testing it.