Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a header component #59

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added a header component #59

wants to merge 2 commits into from

Conversation

Rohanhacker
Copy link

@Rohanhacker Rohanhacker commented May 12, 2018

Fixes #47

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream master branch.
  • I have added/updated necessary tests/documentation (if applicable)

Changes proposed in this pull request:

  • created a Header component

@Rohanhacker
Copy link
Author

Just created a container and didn't added option to add/remove avatar, search and stuff because header component is different for different pages. 😜

@blenderskool
Copy link
Contributor

@Rohanhacker Please check the design guidelines again. Yes, the header component behaves differently in different pages, but in a specific format.

Please include additional styles for search/back icon, avatar, and other use cases.

@Rohanhacker
Copy link
Author

@blenderskool I think we should have different header component for different headers which all use a common base header component

@Rohanhacker
Copy link
Author

@blenderskool We should do it in similar way as ant design does.
https://ant.design/components/layout/#components-layout-demo-top

@palnabarun
Copy link
Collaborator

@Rohanhacker Updated the PR description to include the relevant issue.

@blenderskool
Copy link
Contributor

blenderskool commented May 14, 2018

@Rohanhacker Looking at the docs, I feel default AppBar in Material UI with some overrides can be used. Overrides include:

  • box-shadow

There isn't any other type of header used in the mobile design as of my knowledge

@Rohanhacker
Copy link
Author

Rohanhacker commented May 14, 2018

@blenderskool by different header I meant one with avatar, one with just back btn etc

@Rohanhacker
Copy link
Author

Rohanhacker commented May 14, 2018

@blenderskool I agree material-ui's default components can be used with some override

@blenderskool
Copy link
Contributor

@Rohanhacker Those differences are all in a general component. I think we can pass those changes as children. Let's see how it works out while developing individual pages 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Frontend] Create a Header component
3 participants