Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] Create a Button component #48

Open
1 of 2 tasks
divyamrastogi opened this issue May 9, 2018 · 1 comment · May be fixed by #54
Open
1 of 2 tasks

[Frontend] Create a Button component #48

divyamrastogi opened this issue May 9, 2018 · 1 comment · May be fixed by #54
Labels
Critical This is a critical issue taken issue has been assigned and assignee is on it

Comments

@divyamrastogi
Copy link
Collaborator

divyamrastogi commented May 9, 2018

I'm submitting a ...

  • bug report
  • feature request

Current behavior:
There is no common button

Expected behavior:
We need to create a simple Button component based on this design and that will be easy to reuse
It should work something like this:
<Button type="primary" onClick={someFunction}>Submit</Button>
type : primary|secondary

Note: Make sure that the onClick handler is a prop and do think of other cases in case I've missed any.

@blenderskool
Copy link
Contributor

I will work on this 🙂

@divyamrastogi divyamrastogi added Critical This is a critical issue taken issue has been assigned and assignee is on it labels May 9, 2018
@blenderskool blenderskool linked a pull request May 9, 2018 that will close this issue
3 tasks
@divyamrastogi divyamrastogi changed the title Create a Button component [Frontend] Create a Button component May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical This is a critical issue taken issue has been assigned and assignee is on it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants