-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a header component #59
base: master
Are you sure you want to change the base?
Added a header component #59
Conversation
Just created a container and didn't added option to add/remove avatar, search and stuff because header component is different for different pages. 😜 |
@Rohanhacker Please check the design guidelines again. Yes, the header component behaves differently in different pages, but in a specific format. Please include additional styles for search/back icon, avatar, and other use cases. |
@blenderskool I think we should have different header component for different headers which all use a common base header component |
@blenderskool We should do it in similar way as ant design does. |
@Rohanhacker Updated the PR description to include the relevant issue. |
@Rohanhacker Looking at the docs, I feel default AppBar in Material UI with some overrides can be used. Overrides include:
There isn't any other type of header used in the mobile design as of my knowledge |
@blenderskool by different header I meant one with avatar, one with just back btn etc |
@blenderskool I agree material-ui's default components can be used with some override |
@Rohanhacker Those differences are all in a general component. I think we can pass those changes as children. Let's see how it works out while developing individual pages 🙂 |
Fixes #47
Checklist
master
branch.Changes proposed in this pull request: