Weighted Average #833
Open
Weighted Average #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
I've set up the boilerplate for the weighted mean functionality. This should be a good place to get started. We can run over this during today's meeting. |
|
We have fixed the issue with the |
ASV BenchmarkingBenchmark Comparison ResultsBenchmarks that have improved:
Benchmarks that have stayed the same:
Benchmarks that have got worse:
|
14 tasks
…rray/weighted-mean (#866) * updated mean function with weighted arg * updated weighted-mean functionality in dataarray.py * edited weights to dask array --------- Co-authored-by: Rachel Yuen Sum Tam <[email protected]> Co-authored-by: Rachel Yuen Sum Tam <[email protected]>
philipc2
commented
Sep 13, 2024
philipc2
commented
Oct 22, 2024
| nt.assert_equal(result, expected_weighted_mean) | ||
|
|
||
|
|
||
| def test_csne30_equal_area(): |
There was a problem hiding this comment.
philipc2
commented
Oct 22, 2024
| weighted_mean = (self * weights).sum(axis=-1) / total_weight | ||
|
|
||
| # create a UxDataArray and return it | ||
| return UxDataArray(weighted_mean, uxgrid=self.uxgrid) |
There was a problem hiding this comment.
Need to preserve other parameters:
- Coordiantes
|
UXDataset support |
aaronzedwick
requested changes
Dec 6, 2024
| # compute the total weight | ||
| total_weight = weights.sum() | ||
|
|
||
| # compute weighted mean #assumption on index of dimension (last one is geometry) |
There was a problem hiding this comment.
Suggested change
| # compute weighted mean #assumption on index of dimension (last one is geometry) | |
| # compute the weighted mean, with an assumption on the index of dimension (last one is geometry) |
| This function calculates the weighted mean of a variable, | ||
| using the specified `weights`. If no weights are provided, it will automatically select | ||
| appropriate weights based on whether the variable is face-centered or edge-centered. If | ||
| the variable is neither face nor edge-centered. |
There was a problem hiding this comment.
Suggested change
| the variable is neither face nor edge-centered. | |
| the variable is neither face nor edge-centered a warning is raised, and an unweighted mean is computed instead. |
| uxds = ux.open_dataset(quad_hex_grid_path, quad_hex_data_path_face_centered) | ||
|
|
||
| # expected weighted average computed by hand | ||
| expected_weighted_mean = 297.55 |
There was a problem hiding this comment.
Can you compute this within Python? I think if you can avoid hard coding in the answer that is ideal, although I know this can't always be avoided.
There was a problem hiding this comment.
+1 this! Even if it is inevitable to use constants, they shouldn't be showing up as magic numbers within the code and instead should go into some kind of test constants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #826
Overview
UxDataArray