Fix CI for upload artifact breaking change #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
amstilp
commented
Sep 3, 2024
amstilp
commented
- pin all actions to their latest version, so updates can be handled by dependabot
- fix coverage steps so that it works with the latest version of github actions' upload-artifact (which includes a breaking change to not upload hidden files)
The latest version of the upload-artifact action added a breaking change where hidden files are not uploaded by default. Because the coverage step was creating a hidden file (i.e., prefixed with a dot), the file was not uploaded and the coverage job would fail because it couldn't download the coverage file artifacts. Fix this by: 1. making upload-artifact fail if no files were found, instead of warn 2. creating coverage files that are not hidden
That way, version updates can be made by dependabot in pull requests, and we can fix whatever needs to be fixed in those pull requests instead of in whatever branch we happen to be working in.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #729 +/- ##
=======================================
Coverage 99.01% 99.01%
=======================================
Files 325 325
Lines 30708 30708
=======================================
Hits 30406 30406
Misses 302 302 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.