Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better behavior for inactive users #674

Merged
merged 6 commits into from
Jul 26, 2024

Conversation

amstilp
Copy link
Contributor

@amstilp amstilp commented Jul 26, 2024

  • Show alerts on the user profile page if 1) the user is inactive or 2) the user's linked account is inactive
  • Hide inactive users in the user autocomplete view
  • Do not allow user lookups for inactive users (but you can still manually navigate to their profile page)

and a couple other misc updates:

  • make the alert about linking your account dismissible

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.00%. Comparing base (8cd1f94) to head (25bda17).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #674   +/-   ##
=======================================
  Coverage   99.00%   99.00%           
=======================================
  Files         325      325           
  Lines       30411    30482   +71     
=======================================
+ Hits        30109    30180   +71     
  Misses        302      302           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amstilp amstilp marked this pull request as ready for review July 26, 2024 22:55
@amstilp amstilp merged commit 8002b2c into main Jul 26, 2024
11 checks passed
@amstilp amstilp deleted the feature/better-behavior-for-inactive-users branch July 26, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant