Harmonize dbgap and cdsa updates #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
amstilp
commented
Jun 25, 2024
amstilp
commented
- Show similar information on the templates for dbGaP and CDSA collaborator/accessor/uploader update views.
- Add button to dbGaPApplicationDetail to update collaborators.
Add a button on the dbGaPApplicationDetail view to update the collaborators for that application.
Instead of just creating a Study or StudySite, first check if it exists and get the object if it does. This means that the dbgap example script can be run, and then the CDSA example script can be run afterward, or vice versa.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #627 +/- ##
=======================================
Coverage 98.98% 98.98%
=======================================
Files 321 322 +1
Lines 29839 29885 +46
=======================================
+ Hits 29537 29583 +46
Misses 302 302 ☔ View full report in Codecov by Sentry. |
Show CDSAs where the user is the representative on the user detail page. Previously it was just showing accessors and uploaders.
Change the spacing in the details box such that the definition list has a better appearance. Add alert boxes to the accessors, uploaders, and collaborators tables indicating that the a can contact the CDSA if changes need to be made.
It failed with what looks like some sort of server error somewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.