Allow CDSA reps to see their SignedAgreement detail view #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
amstilp
commented
Jun 19, 2024
•
amstilp
commented
- Allow the representative of an application to access the signed agreement Detail view for that agreement.
- Add a field to SignedAgreement that tracks accessors covered under the application (even if they haven't linked their accounts).
- Add a field to DataAffiliateAgreement that tracks uploaders for that agreement (even if they haven't linked their accounts).
- Add form(s)/view(s) to edit signed agreement accessors and uploaders (staff edit only)
- Show the list of covered users, whether they have a linked account, and whether htey are in the access group on the signed agreement detail page.
- Add a view to audit CDSA access group membership using the previous field.
- Add a view to audit CDSA uploaders using the previous field.
- Also allow anyone covered under the CDSA information to see the same views as the PI.
- Add to user profile
Add a field to SignedAgreement to track accessors for that CDSA. Change the related name for the representative to a non-default value, since there are now two foreign keys to the User model. For Data Affiliate Agreements, also add an uploaders field to track uploaders associated with that agreement.
Add a new viewmixin that controls access to CDSA detail pages. It grants permission to the represenrative of the CDSA, any named accessors or named uploaders to see the detail view for their CDSA. Use the view mixin in the MemberAgreementDetail view, the DataAffiliateDetail view, and the NonDataAffiliateDetail view. Modify the information shown to users who are not CC staff by removing links to pages they can't access and hiding some dates.
For a given CDSA, show the list of accessors (and uploaders if applicable) on the Detail view for that signed agreement.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #614 +/- ##
==========================================
+ Coverage 98.83% 98.98% +0.15%
==========================================
Files 307 321 +14
Lines 25838 29839 +4001
==========================================
+ Hits 25536 29537 +4001
Misses 302 302 ☔ View full report in Codecov by Sentry. |
Since we'll be adding a view to update accessors/uploaders, split the status update view into a new "update" namespace. Then we can have update:status and update:accessors.
Add views to update accessors for all SignedAgreements, as well as uploaders for DataAffiliateAgreements. Add tests.
Add links to the views that update SignedAgremeent accessors or uploaders on the Detail page for the signed agreements.
The DataAffiliateAgreement object already exists, so there is no need to pass the SignedAgreement as a field to it.
Separate the signed agremeent audit namespace into one for SAG (sharing agreement group audit). This is so we can add a separate accessors and maybe uploaders audit later.
This helps show the audit behavior.
Also add tests. Right now, the audit does not display an action because we haven't written that view yet.
This gives the user a name, which is displayed on some pages.
Split the audit explanation into its own template, and include it in the template for both the audit view and the resolve view.
Add the action button to the accessor audit table. Also add a template for this action button that can swap its div using htmx upon success.
Typically we require the min valeu to be 1 in the model definitions, so set it in the factories.
Specifically, the AuditResults classes and the AuditTable classes.
The user profile showed a duplicate of the data access mechanism in some cases due to joining with a many-to-many field. Fix this by adding the distinct() call to the queryset filtering and then add tests to check for this behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.