Consolidate definitions for staff and user tables #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of redefining most columns in both tables, subclass the user table to create the staff table, and define or redefine any columns that need to be added or changed.
Same as dbGaP consolidation.
Same as dbGaP consolidation.
View users likely don't need to see that infomration, and it is available if needed on the workspace detail page. Staff users may want to see it in the tables.
Regular view users do not see the associated data prep workspace tables on the dbGaP and CDSA workspace detail pages.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #525 +/- ##
=======================================
Coverage 98.66% 98.66%
=======================================
Files 292 292
Lines 22721 22739 +18
=======================================
+ Hits 22418 22436 +18
Misses 303 303 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #524