Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change TemplateWorkspace intended_workspace_type to intended_usage as TextField #518

Merged
merged 3 commits into from
Mar 22, 2024

Conversation

amstilp
Copy link
Contributor

@amstilp amstilp commented Mar 22, 2024

No description provided.

amstilp added 3 commits March 22, 2024 16:14
For TemplateWorkspaces, remove the intended_workspace_type field and
add an intended_usage field instead. This is helpful because a
template workspace can be cloned to create one of a couple workspace
types (eg, the genotype template is used for both CDSA and dbGaP).
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.66%. Comparing base (dc215de) to head (4aebaf8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #518      +/-   ##
==========================================
- Coverage   98.67%   98.66%   -0.01%     
==========================================
  Files         291      292       +1     
  Lines       22801    22721      -80     
==========================================
- Hits        22498    22418      -80     
  Misses        303      303              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amstilp amstilp marked this pull request as ready for review March 22, 2024 23:51
@amstilp amstilp merged commit 4d6abca into main Mar 22, 2024
8 checks passed
@amstilp amstilp deleted the feature/template-workspace-intended-type-free-text branch March 22, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant