Add ability to show banner announcements #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
amstilp
commented
Mar 22, 2024
amstilp
commented
- Use the django-constance app to add settings that can be edited in the admin
- Add a SITE_ANNOUNCEMENT setting
- If SITE_ANNOUNCEMENT is non-blank, show an alert with the text of the site announcement
I can't run pip-compile since the macports MariaDB ports are broken due to a change in libxml2, so I manually edited the requirements.txt file. Not ideal.
Add django-constance to the third party apps section, and set the specific required settings for this app. We'll use the database backend for now, since we aren't using redis.
This isn't working locally - maybe we can enable it in prod later.
This was causing the ACM navbar to be much bigger than it needed to be.
This is not documented, but appears to be required: jazzband/django-constance#526
Add the ANNOUNCEMENT_TEXT setting to constance with the default as a blank string: "". If the setting is set to a non-blank string, then show an alert with the announcement. Otherwise, do not show any alert. Add tests.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #513 +/- ##
=======================================
Coverage 98.66% 98.67%
=======================================
Files 291 291
Lines 22773 22801 +28
=======================================
+ Hits 22470 22498 +28
Misses 303 303 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.