Add view to audit all dbGaP Applications and Workspaces at the same time #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of having an abstract base class and subclassing that to audit a dbGaPApplication or a dbGaPWorkspace, instead just use the super class itself. Update dbGaPAccessAudit to be a non-abstract class and to take a queryset of dbGaPApplications and dbGaPWorkspaces to audit. Remove the dbGaPApplicationAccessAudit and dbGaPWorkspaceAccessAudit classes. Note that views and the rest of the app is still broken.
In the view that audits access to a single dbGaPWorkspace, use the revamped dbGaPAccessAudit class instead of the dbGaPWorkspaceAccessAudit class that no longer exists. Update a couple tests where necessary.
Raise an error if the input is not a queryset of the correct model.
When creating a dbGaPApplication using a factory, give the AnVIL access group the name that it would be given if you created it via the create view.
When creating the dbGaP workspace auth domain using dbGaPWrkspace factory, give the auth domain group a name that is related to the workspace name.
As part of this, update the dbGaP DAR factory to match the workpace consent abbreviation as well as code.
Add a view that audits access to all dbGaP workspaces for all applications.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #418 +/- ##
=======================================
Coverage 98.32% 98.32%
=======================================
Files 240 241 +1
Lines 18235 18317 +82
=======================================
+ Hits 17929 18011 +82
Misses 306 306 ☔ View full report in Codecov by Sentry. |
Add a field to the data classes for audit results, and set it automatically as a class attribute for different subclasses. Show the has_access field in the audit results table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a view to do a "full" audit of dbGaP access, which audits access to all dbGaPWorkspaces for all dbGaPApplications.