Add a view showing history for a DAR #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the current DAR list view into this pattern, and out of the dbgap_applications pattern. This is in preparation for adding the history of a given DAR.
Instead of redefining the columns for DAR tables, instead define them once in the original dbGaPDataAccessRequestTable, then subclass that table for the other tables. The columns that need to change can be redfined (or set to None) in the child tables if necessary. Also add a link to the DAR history in some of the tables.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #417 +/- ##
==========================================
+ Coverage 98.31% 98.32% +0.01%
==========================================
Files 239 240 +1
Lines 18108 18235 +127
==========================================
+ Hits 17802 17929 +127
Misses 306 306 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #401