Update to ACM v0.21 and open more views to logged in users #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now, use the same tables for both the staff_view and regular view permissions. This gets the project up and running with the new adapter requirements, and we can modify the tables seen by regular view users in future commits.
Now that users can see the workspace detail page, linkify the workspace column.
Now that people can see the workspace detail page, we can have a link in the CDSAWorkspaceUserTable.
Now that the workspace detail page is viewable to these users, the workspace column can be linkified.
Rename the DefaultWorkspaceTable to DefaultWorkspaceStaffTable, and add a new DefaultWorkspaceUserTable for users with view permission. This matches the naming conventions previously established. In the adapters using the default workspace table, set the table class for view users to DefaultWorkspaceUserTable.
Remove the button after the title, and add the link to the details table.
Add the check and message about linking an AnVIL account to the base template such that it displays an alert on all pages for users who have not yet linked their AnVIL account.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #334 +/- ##
=======================================
Coverage 98.26% 98.27%
=======================================
Files 231 231
Lines 17800 17817 +17
=======================================
+ Hits 17492 17510 +18
+ Misses 308 307 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #328