Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Django 4.2 #297

Merged
merged 3 commits into from
Nov 20, 2023
Merged

Switch to Django 4.2 #297

merged 3 commits into from
Nov 20, 2023

Conversation

amstilp
Copy link
Contributor

@amstilp amstilp commented Nov 20, 2023

No description provided.

Django 4.1 introduces a new warning about changes in Django 5.0.
Modify form rendering in the template following the Django advice:
https://docs.djangoproject.com/en/4.2/releases/4.1/#forms

This only appears to affect the CDSA Invalidation form/view, since
the other forms use the crispy tag to render them.
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fac1db5) 98.26% compared to head (755058d) 98.26%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #297   +/-   ##
=======================================
  Coverage   98.26%   98.26%           
=======================================
  Files         231      231           
  Lines       17791    17791           
=======================================
  Hits        17483    17483           
  Misses        308      308           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amstilp amstilp marked this pull request as ready for review November 20, 2023 23:01
@amstilp amstilp merged commit e250608 into main Nov 20, 2023
6 checks passed
@amstilp amstilp deleted the maint/django-4.2 branch February 6, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant