Rename ExampleWorkspace to ResourceWorkspace #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
amstilp
commented
Nov 13, 2023
amstilp
commented
- Rename the model class itself
- Update names of forms, tables, etc. where appropriate, as well as the adapter
- Add a migration to change the workspace_type from "example" to "resource"
Rename the ExampleWorkspace model to ResourceWorkspace. Update the names of the forms, tests, etc. Do not change the name of the adapter yet.
Add migration to update workspace_type for Example/Resource workspaces. Add tests for the migration. Update other tests that were using the example workspace workspace_type string (e.g., template workspaces).
Finally, change the name of the adapter to ResourceWorkpsaceAdapter, removing the last traces of ExampleWorkspaces.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #272 +/- ##
==========================================
+ Coverage 98.25% 98.26% +0.01%
==========================================
Files 228 231 +3
Lines 17654 17770 +116
==========================================
+ Hits 17346 17462 +116
Misses 308 308 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.