Deploy to staging #268
Merged
Deploy to staging #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This view will have a link to the PRIMED coordinated applications that the CC has imported into dbGaP. It will be publicly viewable, similar to the CDSA records view.
Add a table to display the records without links. Add a view, a template, a new url, and tests.
Add a public dbGaP records page
Add the model, a migration, and tests.
Add tests of the WorkspaceCreate, WorkspaceImport, and WorkspaceDetail views. Note that the create and import views are broken due to a bug in ACM (which will be fixed in the next released version). Update the template show it shows a link back to the target workspace.
Use the new permissions in the user_detail template (view -> staff_view). Add a test to check that the link to the Account page is only shown for users with staff_view permission.
Use the new view -> staff_view permission in the study_detail template. Add a tests to check that the relevant information is displayed iff the user has staff_view permission.
Change the permissions from view -> staff_view. Add tests to check that the information is only displayed when the user has the expected permissions.
Update the permissions in the navitems template for the dbGaP app to use the new permissions in ACM v0.20. Add tests to check that the relevant links are only displayed when appropriate.
Use the new ACM v0.20 permissions in the CDSA nav items template. Add tests to check that information is only displayed when the user has appropriate permissions.
Update the view -> staff_view permissions in the base template. Add tests to ensure that the link to the ACM index page only appears for users with staff_view permission.
Use the new edit -> staff_edit permission in the overridden ACM navbar template. Add tests to check that links only appear when appropriate.
In the tests, fix the permission codenames after merging with main. The main branch is updated to ACM v0.20, which fixes a bug found in this branch but also includes updated permissions.
Fix failures that arose after the ACM bugfix was installed.
The tests for creating different workspace types using the ACM WorkspaceCreate view had unused helper methods to return an api url. Remove these method definitions since they are not being used anywhere in the tests.
Not really thematically part of this branch, but cleans up test coverage.
Update the migration. Show the is_active field in the table. Show the is_active status on the detail page. Add the field to the workspace data form.
The patch version also has a bugfix for the WorkspaceUpdate and WorkspaceClone views for workspace data objects that have a second foreign key to Workspace.
Add a new DataPrepWorkspace workspace type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.