Sort tables alphabetically #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of ordering by pk - this makes more sense for users. Closes #227
Add sensible default orderings to the tables in the dbgap app. This way it is easier for users to find information because tables are not ordered by pk.
The test for rendering number_approved_dars for the dbGaPDataAccessSnapshot table started failing when we changed the ordering of the table. Change the test so is it more robust to that change by testing the render function directly instead of pulling the value out of the table rows and assuming an ordering. Also add a test for the number of requested dars.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
primed_anvil,dbgap, andcdsaapps.This makes it easier for users to find what they're looking for, compared to when tables were just sorted by pk.
Closes #227