Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maint/favicon notfound #840

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Maint/favicon notfound #840

merged 2 commits into from
Nov 21, 2024

Conversation

jmcarson
Copy link
Collaborator

Squash favicon.ico not found errors by adding redirect view to our custom favicon.
Browsers will still load favicon.ico in some cases even if you specify a different favicon in your html head.

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.53%. Comparing base (522554d) to head (a381456).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #840   +/-   ##
=======================================
  Coverage   98.53%   98.53%           
=======================================
  Files         162      162           
  Lines       20506    20506           
=======================================
  Hits        20206    20206           
  Misses        300      300           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@jmcarson jmcarson merged commit a320f5f into main Nov 21, 2024
10 checks passed
@jmcarson jmcarson deleted the maint/favicon-notfound branch November 21, 2024 21:52
@jmcarson jmcarson mentioned this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant