Upload workspace audit - user feedback #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
amstilp
commented
Sep 3, 2024
amstilp
commented
- Only show the can_compute icon for WRITER and OWNER levels
- Color the false icons black instead of red, since they don't indicate errors
- Clean up audit explanations
- Clean up unused code
- Add tests for audit result dataclasses
Instead of having the page title just have a colon followed by nothing when auditing all upload workspaces, instead check if there is an object and if not, display "all upload workspaces". Otherwise, display the object str as before.
This makes more sense; red typically indicates an error while black indicates "no but not a problem".
Do not show can_compute for readers. Also, add tests for the audit result classes so that we can test the get_table_dictionary method. In this case, there is no need to test the individual classes, since they are all just inheriting from the main class without much different behavior.
The auth domain audit explanation still had the previous behavior (before Cat's review and subsequent changes). Update the explanation to reflect the actual behavior.
The coverage job is failing because github added a breaking change in v4.4 of the upload-artifact job such that hidden files were no longer uploaded by default. This breaks the current coverage setup where the coverage file is hidden (.coverage). This change causes the upload-artifact job to fail if no files are found, which is really what we want. With this change, I expect all pytest jobs to fail at the step of uploading the coverage file.
This way they won't be considered hidden files by the upload-artifacts action.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #721 +/- ##
==========================================
+ Coverage 97.93% 97.95% +0.01%
==========================================
Files 149 149
Lines 15900 16040 +140
==========================================
+ Hits 15572 15712 +140
Misses 328 328 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.