Automate adding DCC admins group to workspaces and managed groups #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
amstilp
commented
Aug 8, 2024
amstilp
commented
- Add Workspace adapter methods to automatically share any workspaces that was created or imported with the DCC admins group
- Add ManagedGroup adapter methods to automatically add the DCC admins group to any managed group created via the ManagedGroupCreate view
This setting will be used to automate some tasks, eg sharing workspaces with the admin group or adding it as an admin of any managed group that is created.
This adapter shares a workspace with the admins group upon creation.
This method checks if the workspace is shared with the admins as an owner. If not, it shares it; if it is shared but not as an owner, it updates the sharing.
This way, all workspaces get automatically shared with the admins group.
Add a new adapter that automatically shares any ManagedGroup created via the app view with the GREGOR_DCC_ADMINS group.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #680 +/- ##
==========================================
+ Coverage 93.96% 94.18% +0.22%
==========================================
Files 124 124
Lines 5485 5693 +208
==========================================
+ Hits 5154 5362 +208
Misses 331 331 ☔ View full report in Codecov by Sentry. |
A couple lines of the adapter method were not covered in tests; fix that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.