Add partner upload workspaces #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This table should show the set of PartnerUploadWorkspaces that are contributing to a given upload cycle. The logic is not quite right in the view yet, but it's enough to show adding the table.
This was included in error, and was not doing what I thought. It was causing the wrong objects to be created/obtained in factories.
Because the partner workspaces are not linked directly to an upload cycle, we need to use some logic to get the partner workspaces that should be included in an upload cycle. For a given research center and consent group, only the PartnerUploadWorkspace with the highest version and with a date completed less than the upload cycle end date will be included for that upload cycle. Use this method in the UploadCycleDetail view instead of filtering partner workspaces directly.
Modify the PartnerUploadWorkspaceForm date_completed field to have clearer help text for the user and to use a calendar picker widget for selecting the date.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #398