Skip to content

Commit

Permalink
Update CI to fail if no files are found
Browse files Browse the repository at this point in the history
The coverage job is failing because github added a breaking change
in v4.4 of the upload-artifact job such that hidden files were no
longer uploaded by default. This breaks the current coverage setup
where the coverage file is hidden (.coverage). This change causes
the upload-artifact job to fail if no files are found, which is
really what we want. With this change, I expect all pytest jobs
to fail at the step of uploading the coverage file.
  • Loading branch information
amstilp committed Sep 3, 2024
1 parent f4552b1 commit dd6d56c
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ jobs:
with:
name: coverage-data-${{ strategy.job-index }}
path: .coverage-${{ strategy.job-index }}
if-no-files-found: error

coverage:
needs:
Expand Down

0 comments on commit dd6d56c

Please sign in to comment.