Bugfix: Use custom workspace form when cloning #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the app defined a separate form to use in the WorkspaceClone view. If a user specified a custom workspace form in the adapter, the WorkspaceClone view would ignore that custom form when creating a new workspace of that type, so any custom cleaning was lost. Fix this by changing the WorkspaceCloneForm to a mixin and defining a new form class on the fly in the WorkspaceClone view. This new class subclasses the workspace form specified by the adapter as well as the WorkspaceCloneFormMixin.
This test checks that the custom workspace form is used to create the form for cloning the workspace, by checking that the validation on the form runs correctly. (The test form defines a clean method for the workspace name.)
It is optional anyway.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #538 +/- ##
=======================================
Coverage 99.74% 99.74%
=======================================
Files 135 135
Lines 24197 24265 +68
=======================================
+ Hits 24135 24203 +68
Misses 62 62 ☔ View full report in Codecov by Sentry. |
Move the authorization domain validation to the clean method, instead of having a separate clean_authorization_domains method. This is likely better for inheritance, because people could add their own method for clean_authorization_domains and would be less likely to call the super() method. Forms typically should call the super().clean method in their clean method, and it is shown in django docs, so that is a better place to add the custom auth domain checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #516