Fix unexpected errors with deactivated accounts and managed group membership #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ManagedGroupMembershipAudit currently gives an error if there is a deactivated account that is in a group in the app, but is not in the group on AnVIL. This is expected because the app stores the record of what groups the account was in (so there is a record for the GroupAccountMembership), but removes the account from all groups on AnVIL (so the account email do not appear in the list of members/ admin returned by the AnVIL API). This should not raise an audit error.
Codecov Report
@@ Coverage Diff @@
## main #410 +/- ##
=======================================
Coverage 99.82% 99.82%
=======================================
Files 121 121
Lines 22803 22873 +70
=======================================
+ Hits 22763 22834 +71
+ Misses 40 39 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
The __init__ method failed with an unexpected exception if a group was not managed by the app (AttributeError instead of AnVILNotGroupAdminError). Fix the __init__ method and add a test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #404