Fix/sorted section list 467 #789
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the same form that admin page uses when creating users. RegistrationForm is not affected by change in forms.py in commit: 9be07d3 and thereby did not get a sorted section list from previous change. I do not see the diffrence in accont creation between the two forms.
|
Closing to evaluate if there is another solution to this that is not using the admin creation tool |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Changed the frontend register page to use
CustomUserCreationFormfrom members.forms instead ofRegistrationForm.Also changed CustomUserCreationForm to provided a sorted section list (sorted by the section abbreviation) by using
Section.objects.order_by('abbreviation')instead ofSection.objectsin the filesrc/members/forms.py.Applicable Issues
fixes #467 and makes the sections ordered by their abbreviations