feat: add support for multiple vehicles #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These fileds indicate whether an user has an agreement of a particular type. This change is done to support the upcoming agreement change which allow for a user to either use bocken, the electric bike *hornet* or both.
A user which has an agreement type which does not match that of bocken cannot create a journal entry, if not checked a person with only a agreement that applies to hornet could add entries which would be incorrect.
made migration to initiliaze data and such but no real work in replacing the logic in journal entries and such
need to test and further fix the front-end so that the automatically filled trips are fixed
Added code for fetching the latest status of all of the vehicles dynamically so that it mimics previous behaviour with only a single vehicle
Show the main group and the vehicle driven for the reports so that it is "easier" to collect statistics.
Updated tests for journalentryform to use vehicle, also added tests which check if the user can or can not drive a particular vehicle etc.
sgronlund
changed the title
Now fetches the attribute based on the vehicle id which is stored in the DOM, technically has support for unlimited vehicles but might not as fool proof.
If there were no entries the code didn't fetch the meter stats from the vehicle objects, now it does :)
|
Just curious, does UTN plan on having more vehicles or is this just a feature (a welcomed one)? @sgronlund |
This is implemented since UTN has in fact introduced more vehicles, an electric bike to be exact. |
|
@elsareuter Lint error så ska bara göra en snabb commit som fixar de 😸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
The following pull request attempts to add support for multiple vehicles and types of vehicles within the journal system. Tests have been added to check for this feature, and following are images of how the "new" system looks.
This is marked as a draft for the moment, as I'll do some finishing touches before I am completely satisfied.