Implement style guide in Tailwind config #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I finished changing the colors and font styles according to the given information but there are certain bugs in this for example the line height is not right as often multiple text elements seem to touch each other and also primary-blue-5 and neutral-5 seem to be the same. I don't know if I should delete the previous code or comment it out so I just deleted it.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WillieCubed
changed the title
WillieCubed
requested changes
Apr 17, 2023
Comment on lines
+9
to
+10
| <h1 className="text-headline4 text-[96px] font-bold font-display ">Whoops!</h1> | ||
| {/* <h1 className="text-display-extra-large">Whoops!</h1>*/} |
There was a problem hiding this comment.
Don't forget to remove commented code from changes being merged into develop.
| light: '#6470F7', | ||
| DEFAULT: '#2F3FF4', | ||
| dark: '#0B1CD5', | ||
| 'primary-blue': { |
There was a problem hiding this comment.
This works, but let's rename this to just primary.
| }, | ||
| fontFamily: { | ||
| sans: ['var(--font-sans)', 'Roboto', 'sans-serif'], | ||
| display: ['var(--font-display)', 'Jost', 'Roboto', 'sans-serif'], | ||
| display: ['var(--font-display)', 'Jost', 'Roboto', 'sans-serif', 'Montserrat'], |
There was a problem hiding this comment.
The font Montserrat is never loaded because it's not being imported in the _app.tsx file. Instead of putting this here, update the font corresponding to --font-display in _app.tsx.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
closes #70
I created an internal tool to simplify tailwind css
What Changed
I changed tailwind.config.js to fit new changes in the formats specified to me, adding new changes that abstracts away a lot of tailwind with 'display-text-large' instead of specifying font size, font family, font weight, line height, and letter spacing.
Other Notes
I finished changing the colors and font styles according to the given information but there are certain bugs in this, for example, the line height is not right as often multiple text elements seem to touch each other. I also deleted the previous code that was in tailwind.config.js.