Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created Sidebar #38

Closed
wants to merge 17 commits into from
Closed

Created Sidebar #38

wants to merge 17 commits into from

Conversation

JosephChang1
Copy link
Collaborator

Sidebar prototype created

@JosephChang1 JosephChang1 linked an issue Oct 25, 2022 that may be closed by this pull request
Implement site-wide navigation #30
Open
@vercel
Copy link

vercel bot commented Oct 25, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
survival-guide ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 26, 2023 at 6:02PM (UTC)

@JosephChang1 JosephChang1 self-assigned this Nov 2, 2022
@WillieCubed WillieCubed requested review from vikranthchinnam and removed request for WillieCubed March 15, 2023 23:14
@WillieCubed WillieCubed added this to the MVP - Version 0.1.0 milestone Mar 15, 2023
@WillieCubed WillieCubed removed this from the Release 0.1.0 milestone Mar 21, 2023
vikranthchinnam
vikranthchinnam requested changes Mar 26, 2023
View reviewed changes
Copy link
Collaborator

@vikranthchinnam vikranthchinnam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're using typescript for components which I would request you to change the files to and also can you add the sidebar to the content viewer so I can test it when deployed?

@WillieCubed
Copy link
Member

Closing as stale and as a duplicate of #71.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikranthchinnam vikranthchinnam vikranthchinnam requested changes

Assignees

@JosephChang1 JosephChang1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement site-wide navigation
3 participants
@JosephChang1 @WillieCubed @vikranthchinnam