Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add matching directory hierarchies for the Components and Style folders #55

Closed
wants to merge 1 commit into from

Conversation

AvengingPrime
Copy link
Collaborator

Closes #54. Added a base for a hierarchical directory structure for the components and style folders. This helps better organise the files for later work, and also mitigates any duplicate component naming issues.

@AvengingPrime AvengingPrime linked an issue Feb 8, 2023 that may be closed by this pull request
@vercel
Copy link

vercel bot commented Feb 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
survival-guide ✅ Ready (Inspect) Visit Preview Feb 8, 2023 at 9:02PM (UTC)

@WillieCubed WillieCubed self-requested a review February 8, 2023 21:04
@WillieCubed WillieCubed added the Type: Internal "Chore" tasks that are needed for features label Feb 8, 2023
@WillieCubed
Copy link
Member

Just wanted to verify: is this ready for review? If not, you can mark it as a draft until you're ready.

image

@AvengingPrime
Copy link
Collaborator Author

Just wanted to verify: is this ready for review? If not, you can mark it as a dra

I think so. For now, I've just added higher level directories. As for sub-directories related to different components (i.e. sub directories for the Sidebar and Content Viewer Components in the Content Viewer Page), they will be added by the respective issue's assignee in the actual issue branch. For example, after this gets merged, I'll add the Content Viewer's sub-directories in the content viewer issue.

@WillieCubed
Copy link
Member

I currently only see a single commit with a single new file. If you've created empty directories, they won't show in Git because Git only tracks files. If you would like to go ahead and move the components to use the new directory structure, I would wait until after #40 is merged, merge those changes into this branch, and then refactor from there and leave this as a draft PR until those components are ready.

Additionally, I would keep custom styles (the ones not using Tailwind CSS) in CSS modules that are within a component's subdirectory and refrain from using global styles.

@WillieCubed
Copy link
Member

Closing as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Internal "Chore" tasks that are needed for features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Internal] Hierarchical Directories for Components
2 participants