Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal] Hierarchical Directories for Components #54

Open
AvengingPrime opened this issue Feb 4, 2023 · 3 comments
Open

[Internal] Hierarchical Directories for Components #54

AvengingPrime opened this issue Feb 4, 2023 · 3 comments
Assignees
Labels
Status: Done Has been resolved by code that has been merged into the default branch Type: Internal "Chore" tasks that are needed for features
Milestone

Comments

@AvengingPrime
Copy link
Collaborator

Overview of Proposed Changes

We should add hierarchical directories for the components to remove any issues that arise from identical naming and also to prevent all components being dumped in the same folder. This will allow for a better organisation structure that will be easier to maintain in the future.

Details

Highest Level Folders in the Components directory should refer to different pages, and subsequent component hierarchy should be represented in sub-folders as needed.

@AvengingPrime AvengingPrime added Status: Awaiting Triage Requiring a determination on how to proceed Type: Internal "Chore" tasks that are needed for features labels Feb 4, 2023
@WillieCubed
Copy link
Member

Could you provide an example of a file tree with your proposed changes?

@AvengingPrime
Copy link
Collaborator Author

AvengingPrime commented Feb 6, 2023

Could you provide an example of a file tree with your proposed changes?

image

Something like this.
For sub-directories for issues, it would be upto whoever is working on the issue to devise if sub-directories are needed. So for the Content Viewer, I might add a Header Directory as it might make sense to further group components inside the Content Viewer.

@WillieCubed WillieCubed added this to the MVP - Version 0.1.0 milestone Feb 8, 2023
@AvengingPrime AvengingPrime added Status: Done Has been resolved by code that has been merged into the default branch and removed Status: Awaiting Triage Requiring a determination on how to proceed labels Feb 8, 2023
@AvengingPrime
Copy link
Collaborator Author

It might also make sense to include a matching hierarchical structure in the Style folder for the style sheets, since the same naming and organisational issue would arise there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Done Has been resolved by code that has been merged into the default branch Type: Internal "Chore" tasks that are needed for features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants