Storybook husky #729
Closed
Storybook husky #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay this was not intended but my commits for temporary work on the TRPC optimizations got mixed in. Will resolve this. |
kamui-fin
force-pushed
the
storybook-husky
branch
from
2e4a4f2 to
9ee6a6c
Compare
|
Vercel Preview URL 🚀 : https://planner-d4qc4pghb-utdnebula.vercel.app |
|
Vercel Preview URL 🚀 : https://planner-2at2fwzg5-utdnebula.vercel.app |
auto-merge was automatically disabled
October 31, 2023 13:13
Pull request was converted to draft
|
Making this draft until the TRPC commits are reverted on this branch so we don't accidentally merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two new dev-experience enhancing tools: Storybook and Pre-commit hooks.
Pre-Commit Hooks
Simply formats and lints only the changed (staged) files to avoid pointless CI runs and saves time overall. Runs automatically on commit.
Storybook
Allows developers to develop components seamlessly in an isolated environment, bettering the quality of the components overall. My suggestion is to make writing storybook stories mandatory for new components for robustness. Would love to hear feedback on that @cubetastic33