Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Side-bar opens a New tab #700

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Side-bar opens a New tab #700

wants to merge 1 commit into from

Conversation

hfsasu
Copy link

@hfsasu hfsasu commented Oct 4, 2023

Overview

List the GitHub issues containing the issues relevant to this pull request.

[For example, "Resolves #1, closes #2, fixes #3", etc.]

Describe your changes here at a high level, describing how this PR fits into the
rest of the project.

What Changed

Go more into detail about key files that were modified and why they were
updated. Do not list every file that was modified; only note the ones most
relevant to this feature or bug fix.

Other Notes

If were roadblocks encountered during development that remain unresolved or any
future additions or changes to make, note them here. Otherwise. Feel free to
delete this section if it isn't needed.

@hfsasu hfsasu requested review from a team and akevinge as code owners October 4, 2023 15:42
@hfsasu hfsasu closed this Oct 4, 2023
@hfsasu hfsasu reopened this Oct 4, 2023
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Vercel Preview URL 🚀 : https://planner-nlwd0dn0o-utdnebula.vercel.app
Neon branch 🐘 : https://console.neon.tech/app/projects/noisy-sky-73682380/branches/br-old-butterfly-31745742

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Vercel Preview URL 🚀 : https://planner-8sl6nlygu-utdnebula.vercel.app
Neon branch 🐘 : https://console.neon.tech/app/projects/noisy-sky-73682380/branches/br-old-butterfly-31745742

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Vercel Preview URL 🚀 : https://planner-q8rqhbbuv-utdnebula.vercel.app
Neon branch 🐘 : https://console.neon.tech/app/projects/noisy-sky-73682380/branches/br-old-butterfly-31745742

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Vercel Preview URL 🚀 : https://planner-9e1jheefy-utdnebula.vercel.app
Neon branch 🐘 : https://console.neon.tech/app/projects/noisy-sky-73682380/branches/br-old-butterfly-31745742

akevinge
akevinge requested changes Oct 4, 2023
View reviewed changes
src/components/home/Sidebar.tsx Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Vercel Preview URL 🚀 : https://planner-j0vrw9esn-utdnebula.vercel.app
Neon branch 🐘 : https://console.neon.tech/app/projects/noisy-sky-73682380/branches/br-old-butterfly-31745742

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Vercel Preview URL 🚀 : https://planner-cqqn6xib1-utdnebula.vercel.app
Neon branch 🐘 : https://console.neon.tech/app/projects/noisy-sky-73682380/branches/br-old-butterfly-31745742

@hfsasu hfsasu changed the title New tab branch Side-bar opens a New tab Oct 6, 2023
akevinge
akevinge approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@akevinge akevinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

akevinge
akevinge requested changes Oct 6, 2023
View reviewed changes
Copy link
Member

@akevinge akevinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, profile should not open in new tab

@kamui-fin kamui-fin added Priority: Low We'll get to this....eventually Stalled labels Nov 2, 2023
@github-actions GitHub Actions
Copy link

Vercel Preview URL 🚀 : https://planner-nkhusy4zv-utdnebula.vercel.app
Neon branch 🐘 : https://console.neon.tech/app/projects/noisy-sky-73682380/branches/br-old-butterfly-31745742

@github-actions GitHub Actions
Copy link

Vercel Preview URL 🚀 : https://planner-28s88qcka-utdnebula.vercel.app
Neon branch 🐘 : https://console.neon.tech/app/projects/noisy-sky-73682380/branches/br-old-butterfly-31745742

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akevinge akevinge akevinge requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Priority: Low We'll get to this....eventually Stalled
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set up routing Set up Redux store
3 participants
@hfsasu @akevinge @kamui-fin