Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component Reorganization #240

Merged
merged 17 commits into from
Oct 1, 2024
Merged

Component Reorganization #240

merged 17 commits into from
Oct 1, 2024

Conversation

nl32
Copy link
Contributor

@nl32 nl32 commented Sep 30, 2024

This pr reorganizes the contents of the Components folder so that they are better organized and grouped by the domain they relate to (Header, Directory, etc.)

Some components have been moved into new folders within the components folder, while others have been moved into the app folder. this determination of where things ended up is dependent on where and how the components are consumed.

also ContactIcons was moved to the icons folder.

The searchBar has been extensively broken down in order to try and seperate the debounce logic from the styling itself, this should make it easier to reuse the component in places where the debounce & autocomplete behavior isn't wanted. Other changes to the searchBar will come in a later pr.

Copy link

vercel bot commented Sep 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jupiter ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 0:32am

@nl32 nl32 requested a review from RubenOlano September 30, 2024 16:41
Copy link
Contributor

@RubenOlano RubenOlano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, since you're doing this, we should make the switch over to using Club rather than Org now. Other than that, minor import nitpicks

src/app/directory/create/OfficerSelector.tsx Outdated Show resolved Hide resolved
src/app/manage/[clubId]/create/page.tsx Outdated Show resolved Hide resolved
src/components/admin/OrgSearch.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename this component

src/components/club/directory/OrgDirectoryGrid.tsx Outdated Show resolved Hide resolved
src/app/directory/[id]/page.tsx Outdated Show resolved Hide resolved
src/app/page.tsx Outdated Show resolved Hide resolved
src/components/events/EventLikeButton.tsx Outdated Show resolved Hide resolved
src/components/nav/SidebarItems.tsx Outdated Show resolved Hide resolved
@nl32 nl32 merged commit 959f1ff into develop Oct 1, 2024
3 checks passed
@nl32 nl32 deleted the component-reworks branch October 22, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants