Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JUP-47: improve events page #225

Merged
merged 32 commits into from
Aug 27, 2024
Merged

JUP-47: improve events page #225

merged 32 commits into from
Aug 27, 2024

Conversation

nl32
Copy link
Contributor

@nl32 nl32 commented Apr 18, 2024

Rebuild of the events page that removes filters. There was a long standing issue of figuring out what kind of criteria users might want to filter events by. We struggled to find an answer beyond, events for clubs users have joined, and events users have shown interest in. Filtered event views are available through club listings and the my community page so this added complexity can be removed from the events page.

To achieve this the pr makes these changes:

  • New SearchParams utility to make interacting with searchParams in a type-safe way easier
  • Removing the event sidebar
  • Removing the swappable list and grid views (Always list now)
  • Added improved date picker
  • styling improvements focused on mobile

Copy link

vercel bot commented Apr 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jupiter ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 27, 2024 6:58pm

@nl32 nl32 marked this pull request as ready for review August 27, 2024 18:36
Copy link
Contributor

@KennethImphean KennethImphean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change to not overwhelm the user when looking at events!

Copy link
Contributor

@RubenOlano RubenOlano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nl32 nl32 merged commit d71c990 into develop Aug 27, 2024
3 checks passed
@nl32 nl32 deleted the JUP-47-improve-events-page branch August 27, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants