Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JUP-49 improve club contacts #217

Merged
merged 14 commits into from
Oct 22, 2024
Merged

JUP-49 improve club contacts #217

merged 14 commits into from
Oct 22, 2024

Conversation

nl32
Copy link
Contributor

@nl32 nl32 commented Apr 1, 2024

this pr adds:

  • valid email support.
  • url specific validation for all options.

@nl32 nl32 requested a review from RubenOlano April 1, 2024 22:09
@vercel Vercel
Copy link

vercel bot commented Apr 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jupiter ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 8:05pm

@nl32 nl32 requested a review from danielsuhcompsci April 1, 2024 22:09
RubenOlano
RubenOlano approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@RubenOlano RubenOlano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏽

RubenOlano
RubenOlano requested changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@RubenOlano RubenOlano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discord and email validation seems to work fine

src/utils/contact.ts Show resolved Hide resolved
@Jake3231
Copy link
Contributor

This is looking great!

danielsuhcompsci
danielsuhcompsci approved these changes Apr 20, 2024
View reviewed changes
Copy link
Contributor

@danielsuhcompsci danielsuhcompsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think everything checks out 👌

@nl32 nl32 requested a review from KennethImphean as a code owner October 22, 2024 20:02
@nl32 nl32 merged commit aec08ba into develop Oct 22, 2024
3 checks passed
@nl32 nl32 deleted the JUP-49-improve-contacts branch October 22, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RubenOlano RubenOlano RubenOlano requested changes

@danielsuhcompsci danielsuhcompsci danielsuhcompsci approved these changes

@KennethImphean KennethImphean Awaiting requested review from KennethImphean KennethImphean is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nl32 @Jake3231 @danielsuhcompsci @RubenOlano