-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug repair #60
Bug repair #60
Conversation
drowenhorst-nrl
commented
May 30, 2024
- Hopefully fix issues when using smaller GPUs for NLPAR
- Fix issue when user sends patterns in as Dask arrays (or other non-numpy arrays) to be indexed. May make an additional copy of the data.
Signed-off by: David Rowenhorst <[email protected]>
Signed-off by: David Rowenhorst <[email protected]>
…nt to be indexed. Signed-off by: David Rowenhorst <[email protected]>
@hakonanes Please check for compatibility with kikuchipy 0.9.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your changes here fix my issue reported in pyxem/kikuchipy#675 on my M-series Mac. I've also pulled this branch in GitHub CI to test on the other platforms (pyxem/kikuchipy#676), and all tests pass. Thanks a bunch!
Is your intention then to release a 0.3.1 patch in the near future?
Will actually be a 0.3.2 ... but yeah. Plan on releasing that tomorrow, will be conda-forge probably by Monday (noticed they have been a bit slower recently). |
ee544d9
into
USNavalResearchLaboratory:main
* main: Bug repair (USNavalResearchLaboratory#60)
I'll take a 0.3.2 release as well. If you find the conda-forge bot slow to respond, we can update the feedstock ourselves: https://conda-forge.org/docs/maintainer/updating_pkgs/#example-workflow-for-updating-a-package. The few times I've updated the feedstock manually, I've just
|