-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do not show duplicate images #3
Comments
This is kind-of fixed because angular throws errors on duplicate images inside the
I keep thinking something like the following is going to fix this, but the data isn't on the client-side until the actual image data comes back out. I am pretty baffled as to how angular is identifying the duplicates since if (this.panel.urls.includes(this_url)){
console.log('dup')
} else {
this.panel.urls.push(this_url)
} |
Setting a time delta of higher granularity than the source data will result in duplicated images.
That ok, but even better might be to replace the duplicates with a placeholder image.
I just created a placeholder image
ellipsis.png
and stuck a TODO in the function where this test ought to go.The trouble is that comparing the content of two images w/ different URLs is not easy.
Just another enhancement that is very doable but not worth the time until someone asks for it.
The text was updated successfully, but these errors were encountered: